Skip to content

Feat: raise granular exception types for lock errors #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danjones1618 wants to merge 1 commit into from
Closed

Feat: raise granular exception types for lock errors #3222

danjones1618 wants to merge 1 commit into from
+74 −29

Conversation

@danjones1618
Copy link

@danjones1618 danjones1618 commented May 3, 2024 •
edited
Loading

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This makes the exceptions raised for various LockError more granular which enables better handling from the callee if needed. All new exceptions extend LockError therefore making this a backwards compatible change.

The following new exceptions have been added:

  1. IndefiniteLockError
  2. LockAquireError
  3. LockNotLockedError
  4. LockNotOwnedError

@danjones1618 danjones1618 force-pushed the feat-granular-lock-errors branch from 2a8abd8 to 440e306 Compare June 1, 2024 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

This pull request has been automatically marked as stale due to inactivity.
It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the stale label Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2025

This pull request has been automatically closed due to inactivity.
If you would like to continue this work, please reopen the PR or create a new one.

@github-actions github-actions bot closed this Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danjones1618